Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 1, 2025

Windows requires more work and is left for later.

@fmeum fmeum changed the title WIP: Fix bazel build //... Fix bazel build //... Dec 1, 2025
@fmeum fmeum marked this pull request as ready for review December 1, 2025 16:48
@fmeum fmeum requested review from meteorcloudy and removed request for ahumesky and ted-xie December 1, 2025 16:48
@github-actions github-actions bot added team-Android Issues for Android team team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Dec 1, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 1, 2025

@meteorcloudy I haven't added //... to any CI job yet since I don't want to cause unnecessary build work - I just confirmed this locally. Should I add it for one job per OS?

@meteorcloudy
Copy link
Member

Wow, nice! Yes, please add those in both presubmit.yml and postsubmit.yml for each platform task.

@fmeum fmeum changed the title Fix bazel build //... Fix bazel build //... on Unix Dec 2, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 2, 2025

@meteorcloudy Done, CI should be green. I can send another PR to do the same for bazel test and later look into the Windows situation.

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this work and all the clean up!

@meteorcloudy
Copy link
Member

@iancha1992 Can you help import the third_party changes?

@iancha1992
Copy link
Member

@iancha1992 Can you help import the third_party changes?

@fmeum To import this one, I need you to squash the commits into one. Could you please? Thanks!

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 3, 2025

@iancha1992 Done!

@iancha1992
Copy link
Member

iancha1992 commented Dec 4, 2025

@iancha1992 Can you help import the third_party changes?

@meteorcloudy I've created a request in Gerrit. Please check. Also, please let me know if you want the rest imported after the third party changes. Thanks!

@meteorcloudy
Copy link
Member

@iancha1992 Thanks!

Just noticed https://bazel-review.git.corp.google.com/c/bazel/+/304092 still contains some files that are checked-in internally. Let's import the non-third party changes first, tests should pass without them.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Android Issues for Android team team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants