-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Fix bazel build //... on Unix
#27828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
caa4b0e to
f8e302c
Compare
|
@meteorcloudy I haven't added |
|
Wow, nice! Yes, please add those in both presubmit.yml and postsubmit.yml for each platform task. |
67da4fa to
f730c40
Compare
|
@meteorcloudy Done, CI should be green. I can send another PR to do the same for |
meteorcloudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this work and all the clean up!
|
@iancha1992 Can you help import the third_party changes? |
@fmeum To import this one, I need you to squash the commits into one. Could you please? Thanks! |
ba88080 to
41ea8e6
Compare
|
@iancha1992 Done! |
@meteorcloudy I've created a request in Gerrit. Please check. Also, please let me know if you want the rest imported after the third party changes. Thanks! |
|
@iancha1992 Thanks! Just noticed https://bazel-review.git.corp.google.com/c/bazel/+/304092 still contains some files that are checked-in internally. Let's import the non-third party changes first, tests should pass without them. |
Windows requires more work and is left for later.