Only cancel shared Merkle subtree computations when no longer needed #27819
+1,029
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
27777-path-deduplicator
branch
3 times, most recently
from
ba3e1ed to
7eebe66
Compare
fmeum
changed the title
fmeum
force-pushed
the
27777-path-deduplicator
branch
4 times, most recently
from
4607153 to
be01f76
Compare
github-actions
bot
added
team-Remote-Exec
fmeum
force-pushed
the
27777-path-deduplicator
branch
2 times, most recently
from
4370eff to
b4e7749
Compare
fmeum
force-pushed
the
27777-path-deduplicator
branch
from
b4e7749 to
4447801
Compare
tjgq
requested changes
Dec 4, 2025
src/main/java/com/google/devtools/build/lib/concurrent/TaskDeduplicator.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/concurrent/TaskDeduplicator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/concurrent/TaskDeduplicator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/concurrent/TaskDeduplicator.java
Show resolved
Hide resolved
tjgq
approved these changes
Dec 4, 2025
tjgq
added
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared Merkle subtree computations are now subject to a refcount-based cancelation scheme to ensure that they can continue through dynamic branch cancelations if another execution reuses them.
Fixes #27777