WIP: Fix repo contents cache staleness #27037
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
26450-repo-contents-cache-file-type
branch
from
3f13026 to
17de10f
Compare
Use a UUID to name entries rather than a counter file. This has a number of advantages: * It's simpler. * Moving to the cache no longer requires exclusive locking on the predeclared inputs hash. * Addresses potential repo staleness in case the counters file is lost or overflows an int. # Conflicts: # src/main/java/com/google/devtools/build/lib/bazel/repository/cache/RepoContentsCache.java
fmeum
force-pushed
the
26450-repo-contents-cache-file-type
branch
from
17de10f to
0f328e5
Compare
fmeum
force-pushed
the
26450-repo-contents-cache-file-type
branch
from
e81a652 to
0abff2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #26450