-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: alignment resolved #26572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: alignment resolved #26572
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@gregestren @fweikert can you review this PR !? |
site/en/_index.yaml
Outdated
items: | ||
- heading: What's new?<br><b>—</b> | ||
- heading: "What's new?<br><b>—</b>" | ||
image_path: /images/new_0.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't exist, does it?
site/en/_index.yaml
Outdated
description: > | ||
Catch up on the latest documentation, community events, and programs. | ||
- heading: Roadmap | ||
- heading: "Roadmap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of the "
seem unnecessary to fix the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meisterT I will remove and ping you.
@meisterT I have updated the requirements as discussed. Please take a look and let me know if any further changes are needed. |
I don't see how this should fix anything. The only changes that are left are additional |
@meisterT The components in the row will be organized even if we add the image in the topic, as there is no image in defalut. You can also check by adding a svg in the header which make the UI good. |
Right, this is what I am saying. The PR currently does not fix the issue as the crucial bit is the missing image and does random other changes. We are currently discussing moving off of devsite, which might make changes like this one easier in the future. |
Fix: Align "What's New?" Section Cards Horizontally
Description
This pull request addresses issue #26531, where the cards in the "What's New?" section of the landing page were not perfectly aligned horizontally. The misalignment was caused by uneven image sizes and content lengths, creating an uneven visual appearance.
Changes Made
items_across: 4
and the correct classname for even distribution.Before
The original section had uneven alignment, as shown below:
After
After these changes, all cards in the "What's New?" section should be evenly aligned, improving readability and visual consistency.
Related Issue
Checklist
Please let me know if any further changes are needed!
Closes #26531