[8.2.0] Retry build when RemoteActionFileSystem encounters a missing digest
#25538
+127
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancha1992
added
team-Performance
Member
|
Tests are failing. Please take a look. |
Collaborator
|
#25396 needs to be cherry-picked first. I'll do both. |
Collaborator
Cache evictions encountered during reads of remote files in `RemoteActionFileSystem` now result in the build being retried when `--experimental_remote_cache_eviction_retries` is set to a positive value (the default). This is enabled by implementing the `checkForLostInputs` method on the `RemoteOutputService`, building on the refactoring performed in bazelbuild#25396. Closes bazelbuild#25358. PiperOrigin-RevId: 736064349 Change-Id: Idc70d55138c3366d22ece7f0579b242b3c217da8
Collaborator
|
@coeuvre Looks good now! |
coeuvre
approved these changes
Mar 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
bazelbuild:release-8.2.0
with commit Mar 26, 2025
8212fc9
45 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache evictions encountered during reads of remote files in
RemoteActionFileSystemnow result in the build being retried when--experimental_remote_cache_eviction_retriesis set to a positive value (the default).This is enabled by implementing the
checkForLostInputsmethod on theRemoteOutputService, building on the refactoring performed in #25396.Closes #25358.
PiperOrigin-RevId: 736064349
Change-Id: Idc70d55138c3366d22ece7f0579b242b3c217da8
Commit 85d9cc9