Attach context string to gRPC downloader requests #25442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to correlate individual requests sent to the remote downloader with the repo rule or module extension they originated from.
fmeum
requested review from
Wyverald and
meteorcloudy
and removed request for
a team
github-actions
bot
added
team-ExternalDeps
meteorcloudy
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 8.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Mar 4, 2025
This makes it possible to correlate individual requests sent to the remote downloader with the repo rule or module extension they originated from. Closes bazelbuild#25442. PiperOrigin-RevId: 733425060 Change-Id: I713bbef1b450a27c95f7f263f84c0a198e37fcc2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
This makes it possible to correlate individual requests sent to the remote downloader with the repo rule or module extension they originated from. Closes #25442. PiperOrigin-RevId: 733425060 Change-Id: I713bbef1b450a27c95f7f263f84c0a198e37fcc2 Commit f6aaa32 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
coeuvre
reviewed
Mar 27, 2025
| buildRequestId, | ||
| commandId, | ||
| actionId, | ||
| actionMetadata != null ? actionMetadata.getProgressMessage() : null, |
Member
There was a problem hiding this comment.
Is there a specific reason why we use actionMetadata.getProgressMessage() instead of actionMetadata.getMnemonic()?
I am trying to change the type of actionMetadata to ActionAnalysisMetadata in order to make import of #25448 easier.
Collaborator
Author
There was a problem hiding this comment.
It's actually a bug, could you change it back?
Collaborator
Author
There was a problem hiding this comment.
@iancha1992 Could you track this as a blocker for 8.2.0?
Collaborator
Author
There was a problem hiding this comment.
I sent #25724 to fix this at HEAD first.
Member
|
@bazel-io fork 8.2.0 |
sgowroji
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to correlate individual requests sent to the remote downloader with the repo rule or module extension they originated from.