Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim Workspace Status values #23922

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

tomrenn
Copy link

@tomrenn tomrenn commented Oct 9, 2024

On windows, bazel will run the workspace_status_command, and receive carriage return characters \r even if the workspace_status_command did not include them.

Fixes #13442

PiperOrigin-RevId: 684055158
Change-Id: Idd3bd9c954d64b0a2d674dd7d90cf61c00955917

On windows, bazel will run the workspace_status_command, and receive carriage return characters \r even if the workspace_status_command did not include them.

Fixes bazelbuild#13442

PiperOrigin-RevId: 684055158
Change-Id: Idd3bd9c954d64b0a2d674dd7d90cf61c00955917
@tomrenn tomrenn requested a review from a team as a code owner October 9, 2024 17:10
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 9, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bazelbuild:release-7.4.0 with commit ab63737 Oct 9, 2024
51 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants