[7.4.0] Fix NPE in execlog when runfiles middleman are not top-level #23888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cherry-pick of the compact execlog runfiles changes assumed that runfiles only appear in the top-level tool nested set, but this isn't true for genrules. Instead, as in Bazel 8, it can be assumed that all middleman are also contained in inputs, which makes it possible to remove the extra middleman parameter and pass all runfiles tree information down to transitive log calls.
fmeum
changed the title
|
@meisterT It would be great to get this fix into 7.4.0rc1. Bazel@HEAD is not affected, but I will submit the new test case as a separate PR. |
github-actions
bot
added
the
awaiting-review
meisterT
approved these changes
Oct 7, 2024
meisterT
added
awaiting-PR-merge
iancha1992
removed
the
awaiting-PR-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cherry-pick of the compact execlog runfiles changes assumed that runfiles only appear in the top-level tool nested set, but this isn't true for genrules. Instead, as in Bazel 8, it can be assumed that all middleman are also contained in inputs, which makes it possible to remove the extra middleman parameter and pass all runfiles tree information down to transitive log calls.
Fixes #23884