[7.4.0] Cherry pick install_name and soname features #23862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires adding the `set_install_name` feature to the Unix toolchain on macOS only. The legacy install name patcher is kept around for as long as the flag can be unflipped. RELNOTES[INC]: With the default Unix toolchain on macOS, binaries now use `@rpath` to find their `.dylib` dependencies. This is required to fix issues where tools run during the build couldn't find their dynamic dependencies. Closes bazelbuild#12370 Closes bazelbuild#23090. PiperOrigin-RevId: 678780800 Change-Id: I13a1bb993c13fb2f9d7b358c2881a7ccdafe66cc
This allows correctly setting the `soname` for shared libraries on Linux. This is useful for similar reasons to the macOS `set_install_name` feature. Fixes bazelbuild#18798 Closes bazelbuild#23839. PiperOrigin-RevId: 681847016 Change-Id: I2d3584c9d91564b41c2501e6664e2956f9760e41
github-actions
bot
added
awaiting-review
comius
approved these changes
Oct 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks 62dc3b5 and 0b0d908 which allows setting install_name and soname on shared libraries. No defaults changed here.
Fixes #23842