Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate additional exec constraint logic #23803

Closed
wants to merge 1 commit into from
Closed

Deduplicate additional exec constraint logic #23803

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 28, 2024 •
edited
Loading

Centralize the logic around exec_compatible_with in a single place to simplify the introduction of exec_group_compatible_with.

Work towards #23802

@fmeum fmeum requested a review from a team as a code owner September 28, 2024 12:58
@fmeum fmeum requested review from aranguyen and removed request for a team September 28, 2024 12:58
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Sep 28, 2024
@fmeum fmeum requested review from katre and removed request for aranguyen September 28, 2024 13:16
@fmeum fmeum requested a review from katre September 30, 2024 19:04
@katre katre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 30, 2024
@iancha1992
Copy link
Member

@fmeum Could you please resolve the conflicts? Thanks

cc: @katre

@Wyverald Wyverald added awaiting-user-response Awaiting a response from the author and removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Oct 7, 2024
@fmeum fmeum requested a review from katre October 8, 2024 11:56
@fmeum
Copy link
Collaborator Author

fmeum commented Oct 8, 2024

@iancha1992 Resolved

@copybara-service copybara-service bot closed this in 849014a Oct 9, 2024
@fmeum fmeum deleted the 23802-prefactor branch October 9, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katre katre Awaiting requested review from katre

Assignees
No one assigned
Labels
awaiting-user-response Awaiting a response from the author team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @iancha1992 @katre @Wyverald