Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3.2] Support for using the java rules from @rules_java #23779

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[7.3.2] Support for using the java rules from @rules_java #23779

merged 2 commits into from
Sep 27, 2024

Conversation

hvadehra
Copy link
Member

No description provided.

hvadehra and others added 2 commits September 26, 2024 20:03
@hvadehra @ahumesky
@buildbreaker2021 @cushon @c-mita
[7.3.2] Support for using the java rules from @rules_java (#23591)
66ab4b3 
Co-authored-by: Googler <ahumesky@google.com>
Co-authored-by: Googler <gnish@google.com>
Co-authored-by: Googler <cushon@google.com>
Co-authored-by: Googler <cmita@google.com>
@hvadehra
[7.3.2] Add @rules_cc to the default API allowlist (#23661)
b4e8b53 
PiperOrigin-RevId: 673946235
Change-Id: If20c63df2877aa948032d97795d88d960d9fa6bc (cherry picked from
commit ff2e950)
@hvadehra hvadehra marked this pull request as ready for review September 26, 2024 18:28
@hvadehra hvadehra requested a review from a team as a code owner September 26, 2024 18:28
@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label Sep 26, 2024
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-CPP Issues for C++ rules team-Rules-ObjC Issues for Objective-C maintainers labels Sep 26, 2024
@meteorcloudy meteorcloudy merged commit c3b6ec3 into release-7.3.2 Sep 27, 2024
54 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 27, 2024
@brentleyjones brentleyjones deleted the hvd_java_rules-7.3.2 branch September 27, 2024 13:18
@iancha1992 iancha1992 added this to the 7.3.2 release blockers milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@iancha1992 iancha1992 iancha1992 approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules team-Rules-ObjC Issues for Objective-C maintainers
Projects
None yet
Milestone
7.3.2 release blockers
Development

Successfully merging this pull request may close these issues.
3 participants
@hvadehra @meteorcloudy @iancha1992