Add --incompatible_no_implicit_watch_label
#23750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the flag is flipped, `ctx.path` no longer watches paths. It used to do so for `Label` arguments only, which is inconsistent with how the other `ctx` methods operate now that they also watch files.
github-actions
bot
added
team-ExternalDeps
fmeum
requested review from
meteorcloudy and
Wyverald
and removed request for
meteorcloudy
|
@fmeum should we include this in |
|
@bazel-io fork 7.4.0 |
Wyverald
reviewed
Sep 26, 2024
src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
fmeum
force-pushed
the
23368-incompatible-watch
branch
from
656b046
to
a0d26f2
Compare
|
Can you file an incompatible change issue to document this flag? |
Wyverald
approved these changes
Sep 26, 2024
Wyverald
added
awaiting-PR-merge
|
@meteorcloudy I created #23861. |
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 8, 2024
When the flag is flipped, `ctx.path` no longer watches paths resolved from `Label` parameters and other methods on `ctx` no longer watch such paths even with `watch = "no"`. Closes bazelbuild#23750. PiperOrigin-RevId: 681978073 Change-Id: I9bef5c735db54c971beb806aa1f1a0eb287e3ff2 (cherry picked from commit 5019697)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
When the flag is flipped, `ctx.path` no longer watches paths resolved from `Label` parameters and other methods on `ctx` no longer watch such paths even with `watch = "no"`. Closes #23750. PiperOrigin-RevId: 681978073 Change-Id: I9bef5c735db54c971beb806aa1f1a0eb287e3ff2 (cherry picked from commit 5019697) Closes #23768
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the flag is flipped,
ctx.pathno longer watches paths resolved fromLabelparameters and other methods onctxno longer watch such paths even withwatch = "no".