Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repo marker file parsing robust to version changes #23642

Closed
wants to merge 3 commits into from
Closed

Make repo marker file parsing robust to version changes #23642

wants to merge 3 commits into from

Commits on Sep 17, 2024

  1. Make repo marker file parsing robust to version changes 

    Bazel 7.1.0 and 7.2.0 contains a bug where + characters in labels in the
repository marker files cannot be parsed. This was fixed in
commit d62e0a0. To reduce the rusk of
future bugs in the same area, this change skips parsing the file if the
first line shows that the content will not be used anyway, which should
be reasonably safe if introducing new formats.

Improves bazelbuild#23336 that fixed bazelbuild#23322.
    @moroten
    moroten committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6164d18 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Return the recordedInputValues map from readMarkerFile

    @moroten
    moroten committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5c62f76 View commit details
    Browse the repository at this point in the history

  2. Make default return value static

    @moroten
    moroten committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a5f4189 View commit details
    Browse the repository at this point in the history