Add --ios_device flag for running iOS application on a physical device #23599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I think it's unlikely that folks would accept a new iOS specific flag into bazel itself, there's a goal of removing this type of specifics from bazel. If a flag is required it would probably be preferred to add a starlark flag in rules_apple itself |
Thanks for letting me know. I had the same assumption, but I'm curious to hear what folks will say. |
|
note that it will not get any attention from folks who can merge unless you mark ready for review |
github-actions
bot
added
team-Rules-ObjC
luispadron
added a commit
to bazelbuild/rules_apple
that referenced
this pull request
Sep 14, 2024
…al device (#2527) In Xcode 15, Apple introduced a new command-line tool that allows management of physical devices. This makes it possible to install and launch *_application targets on a physical device without third-party solutions. With these changes, you can now use `bazel run //:iOSApp --ios_multi_cpus=arm64`. Previously, this command would attempt to launch the application on a simulator and fail due to an invalid architecture. Bazel currently lacks a specific flag for specifying device identifiers suitable for this purpose. I created a [PR to Bazel](bazelbuild/bazel#23599) introducing an `--ios_device` flag. However, it's unlikely to be accepted since it's a platform-specific flag. If it is accepted, we can utilize it in the future. For the current implementation, I added astring_flagthat allows passing a device identifier. It can be used like this:--@build_bazel_rules_apple//apple/build_settings:ios_device=<uuid|ecid|serial_number|udid|name|dns_name> . --------- Signed-off-by: Vadim Smal <vadims@spotify.com> Co-authored-by: Luis Padron <heyluispadron@gmail.com> Co-authored-by: Brentley Jones <github@brentleyjones.com>
sewerynplazuk
pushed a commit
to sewerynplazuk/rules_apple
that referenced
this pull request
Sep 20, 2024
…al device (bazelbuild#2527) In Xcode 15, Apple introduced a new command-line tool that allows management of physical devices. This makes it possible to install and launch *_application targets on a physical device without third-party solutions. With these changes, you can now use `bazel run //:iOSApp --ios_multi_cpus=arm64`. Previously, this command would attempt to launch the application on a simulator and fail due to an invalid architecture. Bazel currently lacks a specific flag for specifying device identifiers suitable for this purpose. I created a [PR to Bazel](bazelbuild/bazel#23599) introducing an `--ios_device` flag. However, it's unlikely to be accepted since it's a platform-specific flag. If it is accepted, we can utilize it in the future. For the current implementation, I added astring_flagthat allows passing a device identifier. It can be used like this:--@build_bazel_rules_apple//apple/build_settings:ios_device=<uuid|ecid|serial_number|udid|name|dns_name> . --------- Signed-off-by: Vadim Smal <vadims@spotify.com> Co-authored-by: Luis Padron <heyluispadron@gmail.com> Co-authored-by: Brentley Jones <github@brentleyjones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR in the rules_apple.
In Xcode 15, Apple introduced a new command-line tool that allows management of physical devices. This makes it possible to install and launch *_application targets on a physical device without third-party solutions.
It would be nice to have a Bazel flag to pass a device identifier for this.