Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional_compiler_inputs support to local_defines/defines #23102

Closed
wants to merge 3 commits into from
Closed

Add additional_compiler_inputs support to local_defines/defines #23102

wants to merge 3 commits into from

Conversation

keith
Copy link
Member

@keith keith commented Jul 24, 2024 •
edited
Loading

Fixes #23885

@keith keith requested a review from oquenchil as a code owner July 24, 2024 20:16
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jul 24, 2024
@keith
Copy link
Member Author

keith commented Jul 24, 2024

I'm less sure about defines here, I think local_defines is very reasonable though, general thoughts?

@fmeum
Copy link
Collaborator

fmeum commented Jul 24, 2024

I'm less sure about defines here, I think local_defines is very reasonable though, general thoughts?

local_defines seems reasonable to me, but I would suggest disabling expansion for defines. There is no way to add files to downstream compilation actions, so it also wouldn't make sense to emit paths into them.

@keith
Copy link
Member Author

keith commented Jul 25, 2024

yea makes sense, done

@oquenchil oquenchil requested review from pzembrod and removed request for oquenchil August 1, 2024 13:57
@fmeum
Copy link
Collaborator

fmeum commented Aug 1, 2024

@bazel-io fork 7.4.0

@bazel-io bazel-io mentioned this pull request Aug 1, 2024
Closed
@fmeum
Copy link
Collaborator

fmeum commented Aug 1, 2024 •
edited
Loading

@keith Thanks, this will actually help me write a good test case for path mapping location expansions!

@fmeum
Copy link
Collaborator

fmeum commented Aug 1, 2024

@oquenchil Should this receive the "awaiting-merge" label or are you importing it yourself?

@satyanandak
Copy link

Hi @oquenchil @pzembrod , Since I can see that this PR has been approved, Please let us know whether gTech team should proceed with importing it. Thanks!"

@fmeum
Copy link
Collaborator

fmeum commented Sep 3, 2024

@pzembrod Friendly ping

@fmeum
Copy link
Collaborator

fmeum commented Sep 16, 2024

@oquenchil @pzembrod Friendly ping, I need this for further path mapping work and it has already been approved.

@iancha1992
Copy link
Member

@oquenchil or @pzembrod could you please review this one? Thanks!

@keith keith mentioned this pull request Oct 7, 2024
Closed
@Wyverald Wyverald requested review from trybka and removed request for oquenchil October 9, 2024 21:01
pzembrod
pzembrod approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@pzembrod pzembrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big apologies for missing this for so long!

@pzembrod pzembrod removed the request for review from trybka October 10, 2024 08:34
@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 10, 2024
@fmeum
Copy link
Collaborator

fmeum commented Oct 10, 2024

@bazel-io fork 8.0.0

@bazel-io bazel-io mentioned this pull request Oct 10, 2024
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 10, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Oct 10, 2024
@keith @bazel-io
Add additional_compiler_inputs support to local_defines/defines
de40b4f 
Fixes bazelbuild#23885

Closes bazelbuild#23102.

PiperOrigin-RevId: 684433748
Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a
@bazel-io bazel-io mentioned this pull request Oct 10, 2024
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Oct 10, 2024
@keith @bazel-io
Add additional_compiler_inputs support to local_defines/defines
d580e9f 
Fixes bazelbuild#23885

Closes bazelbuild#23102.

PiperOrigin-RevId: 684433748
Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a
@bazel-io bazel-io mentioned this pull request Oct 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
@bazel-io @keith
[7.4.0] Add additional_compiler_inputs support to local_defines/defin…
af20307 
…es (#23939)

Fixes #23885

Closes #23102.

PiperOrigin-RevId: 684433748
Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a

Commit
c2d316b

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
@bazel-io @keith
[8.0.0] Add additional_compiler_inputs support to local_defines/defin…
85bf48f 
…es (#23940)

Fixes #23885

Closes #23102.

PiperOrigin-RevId: 684433748
Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a

Commit
c2d316b

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kernhanda kernhanda kernhanda approved these changes

@fmeum fmeum fmeum approved these changes

@pzembrod pzembrod pzembrod approved these changes

@oquenchil oquenchil oquenchil approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cc_library.additional_compiler_inputs should be subject to $(location ...) substitution
7 participants
@keith @fmeum @satyanandak @iancha1992 @kernhanda @pzembrod @oquenchil