Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vendoring immediatelly after a normal repo fetch #22953

Closed
wants to merge 1 commit into from
Closed

Fix vendoring immediatelly after a normal repo fetch #22953

wants to merge 1 commit into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Jul 4, 2024 •
edited
Loading

Repo wasn't vendored as expected due to wrong SkyValue cache caused by incorrect equals function.

Related: #19563

@meteorcloudy
Fix vendoring immediatelly after a normal repo fetch
8b3a693 
Repo wasn't vendored as expected due to wrong SkyValue cache caused incorrect
equals function.
@meteorcloudy meteorcloudy removed the request for review from lberki July 4, 2024 14:14
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jul 4, 2024
@meteorcloudy
Copy link
Member Author

@bazel-io fork 7.3.0

@bazel-io bazel-io mentioned this pull request Jul 4, 2024
Closed
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 8, 2024
@copybara-service copybara-service bot closed this in 076bbbb Jul 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 9, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jul 9, 2024
@meteorcloudy @bazel-io
Fix vendoring immediatelly after a normal repo fetch
2ab73dd 
Repo wasn't vendored as expected due to wrong SkyValue cache caused by incorrect equals function.

Related: bazelbuild#19563

Closes bazelbuild#22953.

PiperOrigin-RevId: 650648957
Change-Id: Id31aa7d6f9bcbe2e3eb9e556ae31b3b8e42436bf
@bazel-io bazel-io mentioned this pull request Jul 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
@bazel-io @meteorcloudy
[7.3.0] Fix vendoring immediatelly after a normal repo fetch (#22979)
4021ad9 
Repo wasn't vendored as expected due to wrong SkyValue cache caused by
incorrect equals function.

Related: #19563

Closes #22953.

PiperOrigin-RevId: 650648957
Change-Id: Id31aa7d6f9bcbe2e3eb9e556ae31b3b8e42436bf

Commit
076bbbb

Co-authored-by: Yun Peng <pcloudy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorcloudy @Wyverald