Mark bazel_tools extensions as reproducible #22335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecessary lockfile entries.
github-actions
bot
added
team-Android
|
@bazel-io fork 7.2.0 |
keith
approved these changes
May 13, 2024
Wyverald
approved these changes
May 13, 2024
Wyverald
added
awaiting-PR-merge
|
@Wyverald Something we should keep in mind: When we update Bazel to build with 7.2.0, we might end up with extension repos missing from the lock file that we need to build the test or dist repo cache. Maybe we can use either |
github-actions
bot
removed
the
awaiting-PR-merge
Wyverald
pushed a commit
that referenced
this pull request
May 13, 2024
Removes unnecessary lockfile entries. Closes #22335. PiperOrigin-RevId: 633311588 Change-Id: Ia0ccb2fd14b28123115109db9fa921380319451e
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
Removes unnecessary lockfile entries. Closes #22335. PiperOrigin-RevId: 633311588 Change-Id: Ia0ccb2fd14b28123115109db9fa921380319451e Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fmeum
added
team-ExternalDeps
rrbutani
added a commit
to rrbutani/rules_cc
that referenced
this pull request
Oct 11, 2024
…appropriately `reproducible` was added in Bazel 7.1.0; gating this argument allows older Bazel versions to use rules_cc 0.0.13 and newer. Note that this change (use of `reproducible`) came from Bazel itself in bazelbuild/bazel#22335; it made its way over to `rules_cc` via bazelbuild@c2549f6 (see bazelbuild/bazel@1c4e78a). More context [here](bazel-contrib/toolchains_llvm#389 (comment)).
This was referenced Oct 11, 2024
rrbutani
added a commit
to rrbutani/rules_cc
that referenced
this pull request
Oct 11, 2024
…appropriately `reproducible` was added in Bazel 7.1.0; gating this argument allows older Bazel versions to use rules_cc 0.0.13 and newer. Note that this change (use of `reproducible`) came from Bazel itself in bazelbuild/bazel#22335; it made its way over to `rules_cc` via bazelbuild@c2549f6 (see bazelbuild/bazel@1c4e78a). More context [here](bazel-contrib/toolchains_llvm#389 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary lockfile entries.