Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update for root package_name #22225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-sm
Copy link
Contributor

@matt-sm matt-sm commented May 3, 2024

Adding a note to the docs for native.package_name().

From the root package this will always return an empty string.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 3, 2024
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label May 3, 2024
@@ -231,7 +231,8 @@ NoneType exportsFiles(Sequence<?> srcs, Object visibility, Object licenses, Star
+ "For example, in the BUILD file <code>some/package/BUILD</code>, its value "
+ "will be <code>some/package</code>. "
+ "If the BUILD file calls a function defined in a .bzl file, "
+ "<code>package_name()</code> will match the caller BUILD file package.",
+ "<code>package_name()</code> will match the caller BUILD file package."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please insert a space at the end (after the dot)

@meteorcloudy meteorcloudy added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants