Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxes: cleanup: Hide Set implementation detail for "dirsToCreate" #21430

Closed
wants to merge 1 commit into from

Conversation

metti
Copy link
Contributor

@metti metti commented Feb 20, 2024

The LinkedHashSet implementation detail needs to only be known at construction time. All further users can just rely on the Set interface definition.

The LinkedHashSet implementation detail needs to only be known at
construction time. All further users can just rely on the interface
definition.

Signed-off-by: Matthias Maennich <maennich@google.com>
@github-actions github-actions bot added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Feb 20, 2024
@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 29, 2024
@metti
Copy link
Contributor Author

metti commented Mar 4, 2024

This already landed: c575c06

@metti metti closed this Mar 4, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants