[7.1.0] Do not store the repository name in RepoSpec
#21205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name can instead be set centrally in `BzlmodRepoRuleFunction`. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph. Work towards bazelbuild#20997 Closes bazelbuild#21026. PiperOrigin-RevId: 604256186 Change-Id: Ia49123f016d1512074b04ec458f017f4bbb88233
iancha1992
added
team-ExternalDeps
|
Looks like you might need to run |
@Wyverald hmm.. I just did run it. But looks like it's giving a different error this time. cc: @bazelbuild/triage |
|
ok hang on, the lockfile situation is getting out of hand... let me see if I can update the release-7.1.0 branch to use Bazel 7.0.2 first. |
|
Sent #21209 instead |
auto-merge was automatically disabled
February 6, 2024 08:44
Pull request was closed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name can instead be set centrally in
BzlmodRepoRuleFunction. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph.Work towards #20997
Closes #21026.
Commit a87a8db
PiperOrigin-RevId: 604256186
Change-Id: Ia49123f016d1512074b04ec458f017f4bbb88233