Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Treat the inability to load the Windows filesystem JNI as an error. #21090

Merged
merged 1 commit into from
Jan 27, 2024
Merged

[7.1.0] Treat the inability to load the Windows filesystem JNI as an error. #21090

merged 1 commit into from
Jan 27, 2024

Commits on Jan 26, 2024

  1. [7.1.0] Treat the inability to load the Windows filesystem JNI as an … 

    …error.

Unlike on Unix, we can't fall back to an alternative implementation. Failure to emit an early error would cause later native method calls to produce a less informative error message.

See bazelbuild#20677 for a recent example where this would have been helpful.

Also note some minor changes:
* Since we attempt to load the JNI in two different ways, make sure to propagate both exceptions (one suppressed by the other).
* The default switch case is unnecessary, as errorprone already enforces exhaustiveness.

PiperOrigin-RevId: 595206761
Change-Id: I4b6258d59d9a4fcc9f83418375acc51a32d7f4a4
    @tjgq
    tjgq committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b57448d View commit details
    Browse the repository at this point in the history