Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip --experimental_google_legacy_api #19771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Flip --experimental_google_legacy_api #19771

wants to merge 1 commit into from

Conversation

Bencodes
Copy link
Contributor

@Bencodes Bencodes commented Oct 9, 2023

Flipping experimental_google_legacy_api to make it easier to adopt rules_android Starlark adoption.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 9, 2023
@iancha1992 iancha1992 added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Oct 9, 2023
@Bencodes Bencodes force-pushed the flip-experimental_google_legacy_api branch from 0b38094 to ca1f588 Compare October 11, 2023 21:27
@Bencodes
Copy link
Contributor Author

cc: @ahumesky @ted-xie

@Bencodes Bencodes force-pushed the flip-experimental_google_legacy_api branch from ca1f588 to 6bea92e Compare October 19, 2023 22:09
@ahumesky
Copy link
Contributor

I think it would be better to fix / refactor / finish the android starlark code so that we don't rely on legacy APIs -- do you see a case where this is not possible?

@gregestren gregestren added team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts and removed team-Configurability platforms, toolchains, cquery, select(), config transitions labels Jan 4, 2024
@comius comius added team-Android Issues for Android team awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-user-response Awaiting a response from the author team-Android Issues for Android team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bencodes @ahumesky @comius @gregestren @iancha1992