Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2.0]Allow remote retry max delay to be user configurable #18061

Merged
merged 4 commits into from
Apr 21, 2023

Commits on Apr 12, 2023

  1. Allow remote retry max delay to be user configurable

    This introduces a new option `--remote_retry_max_delay` can be used to change the existing maximum exponential backoff interval used when retrying remote requests. Before this change, there was a hardcoded value controlling this maximum exponential backoff interval, set to `5s`.
    
    Rational
    `remote_retries` is useful in masking over temporary disruptions to a remote cluster. If a cluster experiences temporary downtime, it is useful to allow bazel clients to wait for a period of time for the cluster to recover before bailing and giving up. If users cannot configure the maximum exponential backoff delay, one must set a large number for `remote_retries`, each retry eventually waiting for up to 5s. This allows the bazel client to wait for a reasonable amount of time for the cluster to recover.
    
    The problem here is that under certain cluster failure modes, requests may not be handled and failed quickly, rather they may wait until `remote_timeout` before failing. A large `remote_timeout` combined with a large `remote_retries` could lead to waiting for a very long time before finally bailing on a given action.
    
    If a user can bump the `remote_retry_max_delay`, they can control the retry waiting semantics to their own needs.
    
    Closes bazelbuild#16058.
    
    PiperOrigin-RevId: 523680725
    Change-Id: I21daba78b91d3157362ca85bb7b1cbbef8a94bb3
    joeljeske authored and ShreeM01 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    db1a5ca View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Configuration menu
    Copy the full SHA
    0750a24 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Configuration menu
    Copy the full SHA
    7ac6b59 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48c9172 View commit details
    Browse the repository at this point in the history