Separate prebuilt darwin java_tools for x86_64 and arm64 #17767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
reviewed
Mar 14, 2023
hvadehra
force-pushed
the
hvd_java_tools_darwin_split
branch
4 times, most recently
from
3dd7416
to
f33e31c
Compare
hvadehra
force-pushed
the
hvd_java_tools_darwin_split
branch
from
a4530f3
to
289919b
Compare
hvadehra
changed the title
11 tasks
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
*** Reason for rollback *** Conflicts with #17762 Will instead go with the alternative idea discussed in this PR: #17767 *** Original change description *** Add darwin_arm64 java_tools Build a fat universal binary for java_tools_prebuilt on darwin Work towards: bazelbuild/java_tools#57 and #13944 Closes #16960. PiperOrigin-RevId: 516799739 Change-Id: I2ff5f615bd7c23e38a334bf836c31ed964443c31
keith
approved these changes
Mar 15, 2023
meteorcloudy
approved these changes
Mar 16, 2023
meteorcloudy
added
the
awaiting-PR-merge
meteorcloudy
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Separate prebuilt darwin java_tools for x86_64 and arm64 This is step 1 of #17780 Closes #17767. PiperOrigin-RevId: 517115807 Change-Id: If2bb85a8a15fd126ab52e5738e3d9558da813090 * Update rules_java and remove references to "remote_java_tools_darwin" This is the last step of #17780 This updates rules_java to v5.5.0 for bazel and bazel_tools and cleans up any remaining references to remote_java_tools_darwin, remote_java_tools_test_darwin, and remote_java_tools_darwin_for_testing Closes #17843. PiperOrigin-RevId: 519059189 Change-Id: Ic04f3a2e5cc12e6b7731f6d8a3551553e172e000 * Update java_tools v12.1 bazelbuild/java_tools#69 Closes #18097. PiperOrigin-RevId: 526116409 Change-Id: I4f31046d7e5b149c5035b0ede0699d74685a1eb8 --------- Co-authored-by: hvd <hvadehra@gmail.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
*** Reason for rollback *** Conflicts with bazelbuild#17762 Will instead go with the alternative idea discussed in this PR: bazelbuild#17767 *** Original change description *** Add darwin_arm64 java_tools Build a fat universal binary for java_tools_prebuilt on darwin Work towards: bazelbuild/java_tools#57 and bazelbuild#13944 Closes bazelbuild#16960. PiperOrigin-RevId: 516799739 Change-Id: I2ff5f615bd7c23e38a334bf836c31ed964443c31
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This is step 1 of bazelbuild#17780 Closes bazelbuild#17767. PiperOrigin-RevId: 517115807 Change-Id: If2bb85a8a15fd126ab52e5738e3d9558da813090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 1 of #17780