Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): remove temporary module space created for zip-based binaries #17628

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(python): remove temporary module space created for zip-based binaries #17628

wants to merge 1 commit into from

Commits on Feb 28, 2023

  1. fix(python): remove temporary module space created for zip-based bina… 

    …ries.

PR bazelbuild#15590 accidentally introduced a bug where zip-based binaries weren't
cleaning up the temporary runfiles directory they extracted their zip
into when they were run *outside* of a test invocation.

To fix, explicitly keep track of when the module space needs to be
deleted or not, and pass that long to the code that decides how to
execute the program and how to clean it up afterwards.

Fixes bazelbuild#17342
    @rickeylev
    rickeylev committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    81c5f82 View commit details
    Browse the repository at this point in the history