Handle SIGWINCH under bazel run correctly.
#17301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, after two window resize events we would stop waiting for the child process - this makes sense for other signals but not for SIGWINCH. Fixes bazelbuild#17215
sgowroji
added
team-CLI
|
@meisterT Would this be safe to include in 6.2? |
|
I think so. @bazel-io fork |
|
@bazel-io fork 6.2.0 |
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 13, 2023
…rectly. Previously, after two window resize events we would stop waiting for the child process. `wait` is interrupted by any trapped signal (and we trap all signals), so we need to call it in a loop until the child really exited. Fixes bazelbuild#17215 Closes bazelbuild#17301. PiperOrigin-RevId: 514395755 Change-Id: Ifb763a55d53f230cde8b1ca77761d94ea6e43e1f
ShreeM01
added a commit
that referenced
this pull request
Mar 15, 2023
…rectly. (#17760) Previously, after two window resize events we would stop waiting for the child process. `wait` is interrupted by any trapped signal (and we trap all signals), so we need to call it in a loop until the child really exited. Fixes #17215 Closes #17301. PiperOrigin-RevId: 514395755 Change-Id: Ifb763a55d53f230cde8b1ca77761d94ea6e43e1f Co-authored-by: Tobias Werth <twerth@google.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
…rectly. Previously, after two window resize events we would stop waiting for the child process. `wait` is interrupted by any trapped signal (and we trap all signals), so we need to call it in a loop until the child really exited. Fixes bazelbuild#17215 Closes bazelbuild#17301. PiperOrigin-RevId: 514395755 Change-Id: Ifb763a55d53f230cde8b1ca77761d94ea6e43e1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, after two window resize events we would stop waiting for the child process - this makes sense for other signals but not for SIGWINCH.
Fixes #17215