Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] Remove logic that increases delay between progress updates over time #16606

Merged
merged 1 commit into from
Oct 28, 2022
Merged

[6.0.0] Remove logic that increases delay between progress updates over time #16606

merged 1 commit into from
Oct 28, 2022

Conversation

ShreeM01
Copy link
Contributor

Removes a bit of undocumented behavior that increases the delay between progress updates the longer the build is running. Potentially resolves #16119

Also renamed MAXIMAL_UPDATE_DELAY_MILLIS to MINIMAL_UPDATE_INTERVAL_MILLIS because it is used as a minimum and doesn't affect the delay between messages.

Fixes #16119.

Closes #16221.

RELNOTES[INC]: Bazel no longer increases the delay between progress updates when there is no cursor control.

PiperOrigin-RevId: 484203851
Change-Id: I33f7302ca85b75135744eb6093b618196199a49f

Removes a bit of undocumented behavior that increases the delay between progress updates the longer the build is running.
Potentially resolves #16119

Also renamed `MAXIMAL_UPDATE_DELAY_MILLIS` to `MINIMAL_UPDATE_INTERVAL_MILLIS` because it is used as a minimum and doesn't affect the delay between messages.

Fixes #16119.

Closes #16221.

RELNOTES[INC]: Bazel no longer increases the delay between progress updates when there is no cursor control.

PiperOrigin-RevId: 484203851
Change-Id: I33f7302ca85b75135744eb6093b618196199a49f
@ShreeM01 ShreeM01 merged commit 60e9bf3 into bazelbuild:release-6.0.0 Oct 28, 2022
@tom-cnops
Copy link
Contributor

It seems like this wasn't added to the 6.0.0 release notes, though the functionality was included. Not sure if this is intentional? @kshyanashree

@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Jan 5, 2023

It seems like this wasn't added to the 6.0.0 release notes, though the functionality was included. Not sure if this is intentional? @kshyanashree

Hi @tom-cnops, My apologies! We have added it in our Github 6.0.0 release note. Thank you!

@tom-cnops
Copy link
Contributor

Thanks @kshyanashree
Would it also be possible for me to be added in the acknowledgements?

@ShreeM01
Copy link
Contributor Author

ShreeM01 commented Jan 6, 2023

Thanks @kshyanashree Would it also be possible for me to be added in the acknowledgements?

Sure! It’s done. Thanks @tom-cnops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants