Expose compatibility arguments on java toolchains #16498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows providing the `exec_compatibility_with` and `target_compatibility_with` arguments to native.toolchain from invocations of the local_java_runtime and default_java_toolchain. This is useful for setting constraints on javatoolchains. With the default arguments provided, this does not break the API of these functions. Closes bazelbuild#16497
sgowroji
added
team-Configurability
4 tasks
comius
approved these changes
Nov 18, 2022
comius
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows providing the
exec_compatibility_withandtarget_compatibility_witharguments to native.toolchain from invocations of the local_java_runtime and default_java_toolchain.This is useful for setting constraints on javatoolchains. With the default arguments provided, this does not break the API of these functions.
Closes #16497