Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move newCredentialHelperProvider into GoogleAuthUtils #15941

Closed
wants to merge 2 commits into from
Closed

Move newCredentialHelperProvider into GoogleAuthUtils #15941

wants to merge 2 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Jul 21, 2022

Follow-up on #15930 due to
#15906

Progress on #15856

@Yannic Yannic marked this pull request as ready for review July 21, 2022 17:13
@Yannic Yannic requested a review from a team as a code owner July 21, 2022 17:13
@Yannic
Copy link
Contributor Author

Yannic commented Jul 21, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 21, 2022
@Yannic
Copy link
Contributor Author

Yannic commented Jul 21, 2022

@tjgq PTAL

@bazel-io bazel-io mentioned this pull request Jul 22, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 22, 2022
@ShreeM01 ShreeM01 mentioned this pull request Jul 25, 2022
Merged
ckolli5 added a commit that referenced this pull request Jul 25, 2022
@ShreeM01 @Yannic @ckolli5
Move newCredentialHelperProvider into GoogleAuthUtils (#15973)
508f185 
Follow-up on #15930 due to
#15906

Progress on #15856

Closes #15941.

PiperOrigin-RevId: 462580799
Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yannic @tjgq @bazel-io