Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate input-only settings in transitions #14972

Closed
wants to merge 1 commit into from
Closed

Do not validate input-only settings in transitions #14972

wants to merge 1 commit into from

Commits on Mar 8, 2022

  1. Do not validate input-only settings in transitions 

    Starlark transition logic temporarily explicitly sets all input build
settings of a transition to their defaults. Since bazelbuild#13971, these values
are cleared after the transition. However, since then they have also
been subject to type validation, which is not only unnecessary, but
also breaks in the special case of a string build setting with
allow_multiple.

With this commit, input-only build settings at their literal default
values are removed from the post-transition BuildOptions without going
through validation. This is made possible by a refactoring of
`StarlarkTransition#validate` that extracts the validation logic into a
separate function and also improves some variable names.
    @fmeum
    fmeum committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    37d39a2 View commit details
    Browse the repository at this point in the history