Correct cpu and os values of local_config_cc_toolchains targets
#14844
Conversation
These aren't being used now, but some of them are clearly defined incorrectly. Fix them now to avoid surprises in the future. Also change `aarch64` to `arm64` since `aarch64` is an alias of `arm64`.
|
@gregestren it seems like the github owners aren't working correctly since we didn't get cc'd here? |
| "tvos_sim_arm64": [ | ||
| "@platforms//os:ios", | ||
| "@platforms//cpu:aarch64", | ||
| "@platforms//os:tvos", | ||
| "@platforms//cpu:arm64", | ||
| ], |
There was a problem hiding this comment.
I wondered this in another context but is this one correct? since it's not actually different from tvos_arm64? maybe the name difference is enough?
There was a problem hiding this comment.
A while back we checked in environment constraints for simulator, device, and catalyst into https://github.com/bazelbuild/apple_support/blob/master/constraints/BUILD, but I don't know enough about Bazel's toolchains in a multi-repo situation to know if those would be accessible from here.
| "ios_sim_arm64": [ | ||
| "@platforms//os:ios", | ||
| "@platforms//cpu:aarch64", | ||
| "@platforms//cpu:arm64", | ||
| ], |
Github is reporting errors on https://github.com/bazelbuild/bazel/pull/14614/files. @aiuto can you diagnose? |
|
I'm not sure if you want a merge now or if the comments above are still pending. I'm happy to merge on the signal. |
|
I think we can merge now, this is an improvement as is, we might need to make more improvements in the future, but without this change it's far off in a lot of places |
thii
deleted the
correct-cpu-and-os-values-of-local_config_cc_toolchains-targets
branch
|
@bazel-io fork 5.1 |
These aren't being used now, but some of them are clearly defined incorrectly. Fix them now to avoid surprises in the future. Also change `aarch64` to `arm64` since `aarch64` is an alias of `arm64`. Closes bazelbuild#14844. PiperOrigin-RevId: 433061989 (cherry picked from commit b858ec3)
These aren't being used now, but some of them are clearly defined incorrectly. Fix them now to avoid surprises in the future. Also change `aarch64` to `arm64` since `aarch64` is an alias of `arm64`. Closes bazelbuild#14844. PiperOrigin-RevId: 433061989 (cherry picked from commit b858ec3)
…4995) These aren't being used now, but some of them are clearly defined incorrectly. Fix them now to avoid surprises in the future. Also change `aarch64` to `arm64` since `aarch64` is an alias of `arm64`. Closes #14844. PiperOrigin-RevId: 433061989 (cherry picked from commit b858ec3) Co-authored-by: Thi Doan <t@thi.im>
In Bazel versions from 5.1.0 and older, there was a change [1] which prevents copybara from compiling on Apple Silicon by default. The solution recommended in [2] was to pin `platforms` repository to a newer version where the constraints value for CPP toolchain could be correctly resolved. Without this change, we would need to use Bazel 5.0.0 or older to compile copybara successfully on Apple Silicon. [1]: bazelbuild/bazel#14844 [2]: bazelbuild/bazel#15175
In Bazel versions from 5.1.0 and older, there was a change [1] which prevents copybara from compiling on Apple Silicon by default. The solution recommended in [2] was to pin `platforms` repository to a newer version where the constraints value for CPP toolchain could be correctly resolved. Without this change, we would need to use Bazel 5.0.0 or older to compile copybara successfully on Apple Silicon. [1]: bazelbuild/bazel#14844 [2]: bazelbuild/bazel#15175 Fixes #207 Change-Id: I8f71518f3c569de794fd60acb899d835323fccc9
These aren't being used now, but some of them are clearly defined
incorrectly. Fix them now to avoid surprises in the future. Also change
aarch64toarm64sinceaarch64is an alias ofarm64.