Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Remove uses of -lstdc++ on darwin #14750

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[5.1] Remove uses of -lstdc++ on darwin #14750

merged 1 commit into from
Feb 9, 2022

Commits on Feb 8, 2022

  1. Remove uses of -lstdc++ on darwin 

    This flag has been invalid seemingly since macOS 10.9 from 2013. By
default clang remaps this back to -lc++, but if your linkopts pass
-nodefaultlibs this is not the case, in which case this invalid flag
fails the link. This happened for rust builds where the rust driver
passes this flag intentionally.

For more info see bazelbuild#14395 (comment)

Fixes google/cargo-raze#247 bazelbuild#14395 bazelbuild/rules_rust#226

Closes bazelbuild#14542.

PiperOrigin-RevId: 424588734
(cherry picked from commit 8b60c90)
    @keith @brentleyjones
    keith authored and brentleyjones committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    e2b7475 View commit details
    Browse the repository at this point in the history