Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --project_id to --bes_instance_name #14455

Closed
wants to merge 1 commit into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Dec 20, 2021

This makes it clearer that this flag affects the BES and not, e.g.,
remote cache or execution. --bes_instance_name was chosen to match
--remote_instance_name as closely as possible.

--project_id always seemed very Google/GCP centric, and now that
there are multiple other BES implementations like BuildBuddy or EngFlow
Build and Test UI, it makes sense to change the terminology to follow
the conventions from the REAPI. We will keep --project_id as an alias
for the foreseable future.

This makes it clearer that this flag affects the BES and not, e.g.,
remote cache or execution. `--bes_instance_name` was chosen to match
`--remote_instance_name` as closely as possible.

`--project_id` always seemed very Google/GCP centric, and now that
there are multiple other BES implementations like BuildBuddy or EngFlow
Build and Test UI, it makes sense to change the terminology to follow
the conventions from the REAPI. We will keep `--project_id` as an alias
for the foreseable future.
@Yannic
Copy link
Contributor Author

Yannic commented Dec 20, 2021

@meisterT PTAL

@Yannic Yannic mentioned this pull request Dec 24, 2021
9 tasks
@michaeledgar
Copy link
Contributor

This looks good - I'll pull this in and update the help string while I'm there.

@bazel-io bazel-io closed this in 1160485 Dec 30, 2021
@Yannic Yannic deleted the bes_instance_name branch January 3, 2022 11:23
Yannic added a commit to Yannic/bazel that referenced this pull request Jan 3, 2022
This makes it clearer that this flag affects the BES and not, e.g.,
remote cache or execution. `--bes_instance_name` was chosen to match
`--remote_instance_name` as closely as possible.

`--project_id` always seemed very Google/GCP centric, and now that
there are multiple other BES implementations like BuildBuddy or EngFlow
Build and Test UI, it makes sense to change the terminology to follow
the conventions from the REAPI. We will keep `--project_id` as an alias
for the foreseable future.

Closes bazelbuild#14455.

PiperOrigin-RevId: 418972581
Wyverald pushed a commit that referenced this pull request Jan 4, 2022
This makes it clearer that this flag affects the BES and not, e.g.,
remote cache or execution. `--bes_instance_name` was chosen to match
`--remote_instance_name` as closely as possible.

`--project_id` always seemed very Google/GCP centric, and now that
there are multiple other BES implementations like BuildBuddy or EngFlow
Build and Test UI, it makes sense to change the terminology to follow
the conventions from the REAPI. We will keep `--project_id` as an alias
for the foreseable future.

Closes #14455.

PiperOrigin-RevId: 418972581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants