Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick for 4.2.0: Export proguard specs from aar_import #13705

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Cherrypick for 4.2.0: Export proguard specs from aar_import #13705

merged 1 commit into from
Jul 19, 2021

Commits on Jul 17, 2021

  1. Export proguard specs from aar_import

    **Background**
    #3778
    
    proguard specs from the `aar_import` rule do not get bubbled up to `android_binary`. In this PR, I wire up a `ProguardSpecProvider` from this rule that exports the `proguard.txt` within an AAR if it exists and any transitive proguard specs from the `exports` attribute.
    
    **Changes**
    * Add an `aar_embedded_proguard_extractor` script to extract `proguard.txt` from an AAR if it exists otherwise generate an empty proguard specs file
    * In AarImport, wire up the proguard extractor action and export results through a `ProguardSpecProvider`.
    
    Once this lands, the android rules would need to be bumped.
    
    **Test Plan**
    * Added tests for the extraction python script
    * Added tests for the `aar_import` rule changes
    
    Closes #12749.
    
    PiperOrigin-RevId: 359667674
    benjaminRomano authored and cpsauer committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    ff9919b View commit details
    Browse the repository at this point in the history