Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick for 4.2.0: Fix stripping of macOS loadable bundles #13704

Closed
wants to merge 1 commit into from
Closed

Commits on Jul 17, 2021

  1. Fix stripping of macOS loadable bundles

    Adds `-x` flag to stripping of macOS loadable bundles.
    
    Loadable bundles--i.e. truly dynamically loadable libraries on macOS--cannot be stripped without this flag, since you'd be trying to strip away the all symbols, including those used for dynamic loading. Doing so results in `error: symbols referenced by indirect symbol table entries that can't be stripped`.
    
    `-x` instead leads to the removal of the unneeded local symbols. As Apple notes in their man page: "For dynamic shared libraries, the maximum level of stripping is usually -x (to remove all non-global symbols)."
    
    This should fix #11869
    
    Closes #13314.
    
    PiperOrigin-RevId: 368841977
    cpsauer committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    ac76e47 View commit details
    Browse the repository at this point in the history