Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define version-specific shebangs for the default python runtimes #13414

Closed
wants to merge 1 commit into from

Conversation

rohanjoyce
Copy link
Contributor

Prior to this commit, the python stub generated with the autodetected runtimes will use #!/usr/bin/env python as the shebang line. For modern python3 systems, this may not exist. It's more reliable to have each specific python runtime version specify a shebang of that particular python version.

@lberki
Copy link
Contributor

lberki commented May 17, 2021

@brandjon , WDYT?

Python knowledge is swapped out of my brain, but it looks like this should fix a number of issues e.g. #13379 .

/cc @comius

@craiglabenz
Copy link

Any updates on landing this PR?

@sventiffe
Copy link
Contributor

@lberki @comius @brandjon

@philwo
Copy link
Member

philwo commented Jun 8, 2021

Can we just merge this? It's just four lines of change and all tests pass. Or is there any hidden risk that I'm not aware of? 🤔

@lberki
Copy link
Contributor

lberki commented Jun 8, 2021

Not that I know of. I'll send an internal change to @comius .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-Python Native rules for Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants