Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow UrlRewriter to change protocol, i.e. https->http, and http->https #13115

Closed
wants to merge 1 commit into from
Closed

Allow UrlRewriter to change protocol, i.e. https->http, and http->https #13115

wants to merge 1 commit into from

Conversation

denyska
Copy link
Contributor

@denyska denyska commented Feb 26, 2021

Fixes #13114

@google-cla google-cla bot added the cla: yes label Feb 26, 2021
@coeuvre coeuvre self-requested a review February 26, 2021 06:25
coeuvre
coeuvre approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@denyska
Copy link
Contributor Author

denyska commented Feb 26, 2021

Thanks!
Thnx @coeuvre . Rebased. Please take another look.

@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Mar 1, 2021
@bazel-io bazel-io closed this in 495ac92 Mar 1, 2021
philwo pushed a commit that referenced this pull request Mar 15, 2021
@philwo
Allow UrlRewriter to change protocol, i.e. https->http, and http->https
e6001bb 
Fixes #13114

Closes #13115.

PiperOrigin-RevId: 360172767
philwo pushed a commit that referenced this pull request Mar 15, 2021
@philwo
Allow UrlRewriter to change protocol, i.e. https->http, and http->https
6b8846a 
Fixes #13114

Closes #13115.

PiperOrigin-RevId: 360172767
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
cla: yes team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow UrlRewriter to override protocol
4 participants
@denyska @coeuvre @jin @philwo