Upgrade protobuf to 3.13.0, part 2/3 #12108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does the actual upgrade of Protobuf. I'll send a follow-up to remove the now-unused path-file for `3.11.3` when this has landed (and there is no risk of a rollback). Working towards making Bazel compatible with bazelbuild#11694
|
Sorry, I have no clue why this is not working. I assume you rebased this on top of head? cc @meteorcloudy |
|
I took a look but couldn't find suspicious change to the CI. |
|
@philwo fixed CI, so it runs now |
|
@philwo deployed new CI workers with a non-broken version of the Buildkite agent. I retried the build and expect it to succeed: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/6945 |
@com_google_protobuf//:protobuf_java no longer contains the java-lite classes to avoid having Protobuf classes in the classpath more than once (which could happen before if a program depends on :protobuf_java and :protobuf_javalite).
|
CI passes now, so this is ready for review. |
meteorcloudy
approved these changes
Sep 17, 2020
|
LGTM, I'll import this |
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Oct 22, 2020
This change does the actual upgrade of Protobuf. I'll send a follow-up to remove the now-unused patch-file for `3.11.3` when this has landed (and there is no risk of a rollback). Working towards making Bazel compatible with bazelbuild#11694 Closes bazelbuild#12108. PiperOrigin-RevId: 332196682
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Oct 22, 2020
This change does the actual upgrade of Protobuf. I'll send a follow-up to remove the now-unused patch-file for `3.11.3` when this has landed (and there is no risk of a rollback). Working towards making Bazel compatible with bazelbuild#11694 Closes bazelbuild#12108. PiperOrigin-RevId: 332196682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the actual upgrade of Protobuf. I'll send
a follow-up to remove the now-unused patch-file for
3.11.3when this has landed (and there is no risk of a rollback).
Working towards making Bazel compatible with #11694