No way to tell .bazelignore to ignore all folders of the given name

[gregmagolan]

Description of the problem / feature request:

A .bazelignore pattern such as

node_modules

only ignores the node_modules folder at the root level where the .bazelignore file is. This means that in nodejs projects, every single node_modules folder needs to be explicitly listed in .bazelignore.

Not ignoring a node_modules folder can lead to unexpected build errors as these folders contain downloaded npm dependencies that may contain BUILD files that should be ignored. node_modules folders are almost always all untracked and ignored in .gitignore so there are often left around in subdirectories when changing git branches and these are not easily noticed as they are ignored by git.

Feature requests: what underlying problem are you trying to solve with this feature?

Have .bazelignore patterns that don't start with / match in any directory. This would match the behavior of .gitignore. For example:

# ignore root /node_modules folder
/node_modules

# ignore all folders named node_modules in the root directory or in subdirectories
node_modules

What operating system are you running Bazel on?

OSX

What's the output of bazel info release?

release 0.24.0

Any other information, logs, or outputs that you want to share?

For reference:

• Some good examples of how .gitignore patterns are interpreted: https://www.atlassian.com/git/tutorials/saving-changes/gitignore
• The official .gitignore docs that are harder to follow: https://git-scm.com/docs/gitignore

[gregmagolan]

@alexeagle This issue will be a problem for rules_nodejs users after bazel-contrib/rules_nodejs#704 lands since every yarn_install & npm_install rule will create a node_modules folder somewhere in the user's WORKSPACE that will be ignored by git by default but not by bazel.

[kylecordes]

Indeed, this is a problem.

Expected behavior, from working with other tools that have a ".ignore" file, would be that node_modules ignores that dir anywhere in the tree, while /node_modules ignores it only adjacent to the .ignore file.

[brandjon]

This sounds like a reasonable request. I'm a bit worried that it might be too easy to accidentally exclude a directory, and wonder if the use of a wildcard syntax on anchored patterns might help make it more explicit. But then again, it's probably better to be consistent with .gitignore syntax.

[nkoroste]

better to be consistent with .gitignore syntax

+1 to this

[aiuto]

This is a duplicate of #7093

[guw]

Another discovery: Is Bazel not ignoring the .git folder by default?

[brandjon]

Closing as dup of #7093.