incompatible_disallow_legacy_java_provider: Remove the old style, string-indexed Starlark ‘java’ provider

[iirina]

Flag: --incompatible_disallow_legacy_java_provider
Available since: 0.23 (February 2019 release)
Will be flipped in: 0.25 (April 2019 release)

The old style '.java' provider is removed in favor of JavaInfo.

Migration Notes

All Starlark usages of .java must be replaced by [JavaInfo].

[dslomov]

Please follow the guidance at https://www.bazel.build/breaking-changes-guide.html

[lberki]

/cc @lberki

[lberki]

Can we put back the breaking-change-0.25 label now that the flag is released?

[iirina]

0.25 is not a realistic estimation anymore. 0.26 is safest.

[lberki]

Even thoug there are about six weeks until the April release is released?

[iirina]

There are only 2 weeks until the first RC is cut. Do we have a policy for cherry picking flipping incompatible flags?

[lberki]

Well, let's see who breaks... unfortunately, the migration-* label was missing, so CI run for this flag :(