-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Open
Labels
team-Remote-ExecIssues and PRs for the Execution (Remote) teamIssues and PRs for the Execution (Remote) teamtype: buguntriaged
Description
--experimental_remote_mark_tool_inputs is required for remote persistent workers to function correctly:
- https://www.buildbuddy.io/docs/rbe-platforms/#remote-persistent-worker-properties
- https://docs.engflow.com/re/client/remote-persistent-workers.html#client-side-requirements
- https://github.com/buildfarm/buildfarm/blob/127b6c6ad97cc2fc3933aa95646a219c5473598d/src/main/java/build/buildfarm/worker/Executor.java#L488
This flag was first introduced in Bazel 6.0.0, and doesn't describe any reason users should keep it disabled. As-is, this appears to be unnecessary boilerplate for remote persistent workers. One of the following should be done:
- Enable the flag by default, and target a version for removal.
- Document the tradeoff that justifies why this flag is off by default.
Metadata
Metadata
Assignees
Labels
team-Remote-ExecIssues and PRs for the Execution (Remote) teamIssues and PRs for the Execution (Remote) teamtype: buguntriaged