Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Add conlyopts and cxxopts attributes to cc rules #23840

Closed
bazel-io opened this issue Oct 2, 2024 · 3 comments
Closed

[7.4.0] Add conlyopts and cxxopts attributes to cc rules #23840

bazel-io opened this issue Oct 2, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Oct 2, 2024

Forked from #23792
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Oct 2, 2024
@keertk keertk modified the milestone: 7.4.0 release blockers Oct 8, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Oct 8, 2024

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/starlark/builtins_bzl/common/cc/attrs.bzl
src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl
src/main/starlark/builtins_bzl/common/cc/cc_library.bzl

cc: @bazelbuild/triage

@fmeum
Copy link
Collaborator

fmeum commented Oct 8, 2024

@keith

keith added a commit to keith/bazel that referenced this issue Oct 8, 2024
@keith
[7.4.0] Add conlyopts and cxxopts attributes to cc rules
0ca68c4 
The inability to pass C or C++ specific compiler flags to targets that
contain a mix of those sources is a common sticking point for new users.
These mirror the global `--conlyopt` and `--cxxopt` flags but at the
target level.

Fixes bazelbuild#22041

RELNOTES: Add conlyopts and cxxopts attributes to cc rules

Closes bazelbuild#23840

PiperOrigin-RevId: 682144094
Change-Id: I0fe8b728c493652d875ce6a6dd2a9989c36b1f24

(cherry picked from commit 5854788)
@keith keith mentioned this issue Oct 8, 2024
Merged
@keith
Copy link
Member

keith commented Oct 8, 2024

thanks! #23904

github-merge-queue bot pushed a commit that referenced this issue Oct 9, 2024
@keith
[7.4.0] Add conlyopts and cxxopts attributes to cc rules (#23904)
1ee37c1 
The inability to pass C or C++ specific compiler flags to targets that
contain a mix of those sources is a common sticking point for new users.
These mirror the global `--conlyopt` and `--cxxopt` flags but at the
target level.

Fixes #22041

RELNOTES: Add conlyopts and cxxopts attributes to cc rules

Closes #23840

PiperOrigin-RevId: 682144094
Change-Id: I0fe8b728c493652d875ce6a6dd2a9989c36b1f24

(cherry picked from commit 5854788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
5 participants
@keith @fmeum @bazel-io @keertk @iancha1992