Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh_binary to return RunEnvironmentInfo provider #23658

Open
darkrift opened this issue Sep 18, 2024 · 0 comments · May be fixed by #23732
Open

sh_binary to return RunEnvironmentInfo provider #23658

darkrift opened this issue Sep 18, 2024 · 0 comments · May be fixed by #23732
Labels
team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols type: feature request untriaged

Comments

@darkrift
Copy link

Description of the feature request:

When introspecting and wrapping sh_binary rules, there is no way to extract the various run informations such as env var, args, etc which limits the possible integration with wrappers that would like to augment those informations

Which category does this issue belong to?

No response

What underlying problem are you trying to solve with this feature?

Using rules_itest in order to run integration tests, it allows to supplement the RunEnvironmentInfo of the target but in the case of sh_binary, the args and env attributes needs to be redeclared and copied which leads to maintenance pain due to the duplication and a bad developer experience.

Which operating system are you running Bazel on?

MacOS aarch64

What is the output of bazel info release?

release 7.3.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

The only issue I found referring to this is #7364 but is not quite what I'm looking for

Any other information, logs, or outputs that you want to share?

No response

@iancha1992 iancha1992 added the team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols label Sep 18, 2024
@fmeum fmeum linked a pull request Sep 27, 2024 that will close this issue
copybara-service bot pushed a commit that referenced this issue Oct 1, 2024
Work towards #23658

RELNOTES[inc]: Only `sh_library` targets are permitted in the `deps` of `sh_library` rules. Other rules were previously permitted with a warning, but now need to be moved to `srcs` or `data`.

Closes #23660.

PiperOrigin-RevId: 680921907
Change-Id: I0a43473d603a56644a8485a6b83896ccd5ec9088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols type: feature request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants