Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3.0] Push makeExecutable down into AbstractFileWriteAction subclasses #22749

Closed
bazel-io opened this issue Jun 14, 2024 · 2 comments
Closed

[7.3.0] Push makeExecutable down into AbstractFileWriteAction subclasses #22749

bazel-io opened this issue Jun 14, 2024 · 2 comments
Milestone
7.3.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #22609
@bazel-io bazel-io added this to the 7.3.0 release blockers milestone Jun 14, 2024
@bazel-io
Copy link
Member Author

Cherry-picked in #22750

@fmeum fmeum mentioned this issue Jun 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 21, 2024
@fmeum
[7.3.0] Push makeExecutable down into AbstractFileWriteAction sub…
83974e0 
…classes (#22845)

Getting rid of the single boolean field on `AbstractFileWriteAction`
reduces padding on each subclass instance and in particular frees up a
4-byte field on `CppModuleMapAction`.

Also use a lambda to define `newDeterministicWriter` if possible for
improved readability.

This prepares for future changes that will add fields to
`CppModuleMapAction` to support path mapping.

Work towards #6526

Closes #22609.

PiperOrigin-RevId: 643340715
Change-Id: Id3af26049098e6dfa731f0e7a1be6709bea0d9f2

Closes #22749 
Closes #22750
@iancha1992
Copy link
Member

Cherry-picked in #22845 @fmeum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992