Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objc_library targets cannot have .h files in the "srcs" attribute #159

Closed
jbeder opened this issue Apr 25, 2015 · 2 comments
Closed

objc_library targets cannot have .h files in the "srcs" attribute #159

jbeder opened this issue Apr 25, 2015 · 2 comments
Assignees
@calpeyser
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple
Milestone
1.0

Comments

@jbeder
Copy link

jbeder commented Apr 25, 2015

cc_library lets you specify .h files in "srcs", but objc_library does not. Is this intended?

An obvious workaround is to put the .h files in "hdrs", but that allows them to be included in later dependent targets, which isn't always desired.
@ulfjack
Copy link
Contributor

ulfjack commented Apr 27, 2015

I don't think this is intended.

@damienmg damienmg added type: bug P3 We're not considering working on this, but happy to review a PR. (No assignee) Native rules (Java / C++ / Python) labels Nov 17, 2015
@mnett mnett mentioned this issue Jan 17, 2016
Closed
@ulfjack ulfjack added this to the 1.0 milestone Jun 15, 2016
bazel-io pushed a commit that referenced this issue Mar 20, 2017
@hermione521
Rollback of commit 59180a4.
5e60e38 
*** Reason for rollback ***

Break bazel-tests and many other jobs on CI.
http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/651/console

*** Original change description ***

Add SpawnInputExpander helper class to arrange runfiles for spawn strategies

This new class is a combination of SpawnHelper and our internal code; the
plan is to migrate all spawn strategies to the new class. The strict flag
should be enabled by default, but that's a breaking change, so we need to do
it later.

- Use it in SandboxStrategy.
- Add ActionInput.getExecPath to return a PathFragment; this avoids lots of
  back and forth between path fragments and strings.

This is a step towards #159...

***

--
PiperOrigin-RevId: 150610616
MOS_MIGRATED_REVID=150610616
@ob
Copy link
Contributor

ob commented Aug 31, 2018

This is fixed AFAICT.

@ob ob unassigned dmishe Aug 31, 2018
@aiuto aiuto added z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple and removed category: rules > ObjC / iOS / J2ObjC labels Mar 18, 2019
@jmmv jmmv closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calpeyser calpeyser

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
9 participants
@ob @dmishe @philwo @jmmv @jbeder @aiuto @damienmg @calpeyser @ulfjack