Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adding custom fragments #1487

Closed
abergmeier opened this issue Jul 8, 2016 · 2 comments
Closed

Enable adding custom fragments #1487

abergmeier opened this issue Jul 8, 2016 · 2 comments
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request untriaged

Comments

@abergmeier
Copy link
Contributor

abergmeier commented Jul 8, 2016

While ctx.fragments.[fragment name] is nice it currently seems like we cannot use it for custom tools.
It would be great if it would be able to add custom fragments either with the .rc mechanism or from a repository_rule.
Would imaging that ctx.fragments[<repo_name>//<fragment name>] would be a good way of accessing them.

@dslomov
Copy link
Contributor

dslomov commented Jul 8, 2016

Yes, agreed. This is something we plan to have at some point, but it is not
around the corner.

Dmitry

On Fri, Jul 8, 2016 at 11:39 AM, Andreas Bergmeier <notifications@github.com

wrote:

While ctx.fragments.[fragment name] is nice it currently seems like we
cannot use it for custom tools.
It would be great if it would be able to add custom fragments either with
the .rc mechanism or from a repository_rule.
Would imaging that ctx.fragments[<repo_name>//] would be a
good way of accessing them.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1487, or mute the thread
https://github.com/notifications/unsubscribe/AExrXyb-eX3uhAoA0K024qQ4ShjKZJ4zks5qThrsgaJpZM4JH3_F
.

Google Germany GmbH
Erika-Mann-Straße 33, 80636 München, Germany

@aehlig aehlig added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) category: extensibility > skylark labels Jul 8, 2016
@dslomov dslomov added this to the 0.6 milestone Dec 8, 2016
@laurentlb laurentlb removed this from the 0.6 milestone Nov 29, 2018
@brandjon brandjon added team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark labels Feb 15, 2021
@gregestren
Copy link
Contributor

Custom fragments can now be modeled by Starlark configuration (see the notes on "fragments" in the doc).

In other words, Starlark is now powerful enough that anyone can model a fragment without needing special Bazel support. This can work with both native and Starlark flags. The details would depend on exactly what you mean by custom tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request untriaged
Projects
None yet
Development

No branches or pull requests

6 participants