Skip to content

Commit

Permalink
Delete marker file before fetching an external repository (#14324)
Browse files Browse the repository at this point in the history
Fetching a repository is a long-running operation that can easily be
interrupted. If it is and the marker file exists on disk, a new
evaluation of the RepositoryDelegatorFunction may treat this repository
as valid even though it is in an inconsistent state.

Clearing the marker file before initiating the fetch and only recreating
it after the fetch is complete prevents this scenario.

Fixes #8993.

Closes #14302.

PiperOrigin-RevId: 412101756
  • Loading branch information
fmeum authored Nov 25, 2021
1 parent 748138f commit dd8fe77
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,11 @@ && managedDirectoriesExist(directories.getWorkspace(), managedDirectories)) {
}

if (isFetch.get()) {
// Fetching a repository is a long-running operation that can easily be interrupted. If it is
// and the marker file exists on disk, a new call of this method may treat this repository as
// valid even though it is in an inconsistent state. Clear the marker file and only recreate
// it after fetching is done to prevent this scenario.
DigestWriter.clearMarkerFile(directories, repositoryName);
// Fetching enabled, go ahead.
RepositoryDirectoryValue.Builder builder =
fetchRepository(skyKey, repoRoot, env, digestWriter.getMarkerData(), handler, rule);
Expand Down

0 comments on commit dd8fe77

Please sign in to comment.