-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce top-down action caching in Bazel. The top-down cache may be…
… provided by a Bazel module. The cache works by first computing a _transitive_ cache key for the action, known as a sketch. It composes the action keys for all dependent actions and all transitive source file digest hashes. This feature is not currently wired up for use - consider it extremely experimental at this point. RELNOTES: None PiperOrigin-RevId: 260973078
- Loading branch information
1 parent
d5f514b
commit c5c078c
Showing
17 changed files
with
505 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/main/java/com/google/devtools/build/lib/actionsketch/BUILD
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package( | ||
| default_visibility = ["//src:__subpackages__"], | ||
| ) | ||
|
|
||
| filegroup( | ||
| name = "srcs", | ||
| srcs = glob(["**"]), | ||
| ) | ||
|
|
||
| java_library( | ||
| name = "action_sketch", | ||
| srcs = glob(["*.java"]), | ||
| deps = [ | ||
| "//src/main/java/com/google/devtools/build/lib/actions", | ||
| "//src/main/java/com/google/devtools/build/skyframe:skyframe-objects", | ||
| "//third_party:auto_value", | ||
| "//third_party:guava", | ||
| "//third_party:jsr305", | ||
| "//third_party/protobuf:protobuf_java", | ||
| ], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 142 additions & 0 deletions
142
src/main/java/com/google/devtools/build/lib/skyframe/ActionSketchFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| // Copyright 2019 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package com.google.devtools.build.lib.skyframe; | ||
|
|
||
| import com.google.common.cache.CacheBuilder; | ||
| import com.google.common.cache.CacheLoader; | ||
| import com.google.common.cache.LoadingCache; | ||
| import com.google.devtools.build.lib.actions.Action; | ||
| import com.google.devtools.build.lib.actions.ActionKeyContext; | ||
| import com.google.devtools.build.lib.actions.ActionLookupData; | ||
| import com.google.devtools.build.lib.actions.ActionLookupValue; | ||
| import com.google.devtools.build.lib.actions.Artifact; | ||
| import com.google.devtools.build.lib.actions.Artifact.DerivedArtifact; | ||
| import com.google.devtools.build.lib.actions.FileArtifactValue; | ||
| import com.google.devtools.build.lib.actionsketch.ActionSketch; | ||
| import com.google.devtools.build.lib.actionsketch.Sketches; | ||
| import com.google.devtools.build.lib.concurrent.BlazeInterners; | ||
| import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; | ||
| import com.google.devtools.build.lib.util.BigIntegerFingerprintUtils; | ||
| import com.google.devtools.build.skyframe.AbstractSkyKey; | ||
| import com.google.devtools.build.skyframe.SkyFunction; | ||
| import com.google.devtools.build.skyframe.SkyFunctionName; | ||
| import com.google.devtools.build.skyframe.SkyKey; | ||
| import com.google.devtools.build.skyframe.SkyValue; | ||
| import java.math.BigInteger; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * {@link ActionSketchFunction} computes an {@link ActionSketch} for the given Action. This is a | ||
| * transitive hash of the dependent action keys and source file content hashes. | ||
| */ | ||
| public final class ActionSketchFunction implements SkyFunction { | ||
| private final ActionKeyContext actionKeyContext; | ||
|
|
||
| public ActionSketchFunction(ActionKeyContext actionKeyContext) { | ||
| this.actionKeyContext = actionKeyContext; | ||
| } | ||
|
|
||
| public static SketchKey key(ActionLookupData key) { | ||
| return SketchKey.create(key); | ||
| } | ||
|
|
||
| @AutoCodec.VisibleForSerialization | ||
| @AutoCodec | ||
| static class SketchKey extends AbstractSkyKey<ActionLookupData> { | ||
| private static final LoadingCache<ActionLookupData, SketchKey> keyCache = | ||
| CacheBuilder.newBuilder() | ||
| .weakKeys() | ||
| .concurrencyLevel(BlazeInterners.concurrencyLevel()) | ||
| .build(CacheLoader.from(SketchKey::new)); | ||
|
|
||
| private SketchKey(ActionLookupData arg) { | ||
| super(arg); | ||
| } | ||
|
|
||
| @AutoCodec.VisibleForSerialization | ||
| @AutoCodec.Instantiator | ||
| static SketchKey create(ActionLookupData arg) { | ||
| return keyCache.getUnchecked(arg); | ||
| } | ||
|
|
||
| @Override | ||
| public SkyFunctionName functionName() { | ||
| return SkyFunctions.ACTION_SKETCH; | ||
| } | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public String extractTag(SkyKey skyKey) { | ||
| return null; | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public SkyValue compute(SkyKey skyKey, Environment env) throws InterruptedException { | ||
| ActionLookupData actionLookupData = (ActionLookupData) skyKey.argument(); | ||
| ActionLookupValue actionLookupValue = | ||
| ArtifactFunction.getActionLookupValue(actionLookupData.getActionLookupKey(), env); | ||
| if (actionLookupValue == null) { | ||
| return null; | ||
| } | ||
|
|
||
| Action action = actionLookupValue.getAction(actionLookupData.getActionIndex()); | ||
| List<Artifact> srcArtifacts = new ArrayList<>(); | ||
| List<SketchKey> depActions = new ArrayList<>(); | ||
| for (Artifact artifact : action.getInputs()) { | ||
| if (artifact.isSourceArtifact()) { | ||
| srcArtifacts.add(artifact); | ||
| } else { | ||
| depActions.add(SketchKey.create(((DerivedArtifact) artifact).getGeneratingActionKey())); | ||
| } | ||
| } | ||
|
|
||
| Map<SkyKey, SkyValue> srcArtifactValues = env.getValues(srcArtifacts); | ||
| Map<SkyKey, SkyValue> depSketchValues = env.getValues(depActions); | ||
| if (env.valuesMissing()) { | ||
| return null; | ||
| } | ||
|
|
||
| BigInteger transitiveActionKeyHash = Sketches.computeActionKey(action, actionKeyContext); | ||
| BigInteger transitiveSourceHash = BigInteger.ZERO; | ||
|
|
||
| // Incorporate the direct source values. | ||
| for (SkyValue val : srcArtifactValues.values()) { | ||
| FileArtifactValue fileArtifactValue = (FileArtifactValue) val; | ||
| transitiveSourceHash = | ||
| BigIntegerFingerprintUtils.compose( | ||
| transitiveSourceHash, fileArtifactValue.getValueFingerprint()); | ||
| } | ||
|
|
||
| // Incorporate the transitive action key and source values. | ||
| for (SkyValue sketchVal : depSketchValues.values()) { | ||
| ActionSketch depSketch = (ActionSketch) sketchVal; | ||
| transitiveActionKeyHash = | ||
| BigIntegerFingerprintUtils.compose( | ||
| transitiveActionKeyHash, depSketch.transitiveActionLookupHash()); | ||
| transitiveSourceHash = | ||
| BigIntegerFingerprintUtils.compose( | ||
| transitiveSourceHash, depSketch.transitiveSourceHash()); | ||
| } | ||
|
|
||
| return ActionSketch.builder() | ||
| .setTransitiveActionLookupHash(transitiveActionKeyHash) | ||
| .setTransitiveSourceHash(transitiveSourceHash) | ||
| .build(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.