Skip to content

Commit

Permalink
Offer Shell completion for top-level packages without subpackages
Browse files Browse the repository at this point in the history
`bazel build //` now completes to `bazel build //:` when there are no
packages beneath the top-level package. While this is mostly an edge
case that doesn't apply to real projects, it will become more relevant
when completion support is added for external repositories in a future
PR.
  • Loading branch information
fmeum committed Dec 27, 2023
1 parent 71787cf commit 16e9f13
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
12 changes: 12 additions & 0 deletions scripts/bash_completion_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -794,4 +794,16 @@ test_workspace_boundary() {
'build //sub_repo/'
}

test_complete_root_package() {
mkdir pkgs_repo
touch pkgs_repo/WORKSPACE
cat > pkgs_repo/BUILD <<'EOF'
cc_binary(name = "main")
EOF
cd pkgs_repo 2>/dev/null

assert_expansion 'build //' \
'build //:'
}

run_suite "Tests of bash completion of 'blaze' command."
8 changes: 8 additions & 0 deletions scripts/bazel-complete-template.bash
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,14 @@ _bazel__expand_package_name() {
fi
fi
done
# The loop over the compgen -d output above does not include the top-level
# package.
if [ -f $root$current/BUILD.bazel -o -f $root$current/BUILD ]; then
found=1
if [ "${type}" != "label-package" ]; then
echo "${current}:"
fi
fi
[ $found -gt 0 ] && break # Stop searching package path upon first match.
done
}
Expand Down

0 comments on commit 16e9f13

Please sign in to comment.