-
Notifications
You must be signed in to change notification settings - Fork 57
Add new EngFlow logo and update descriptions #325
Add new EngFlow logo and update descriptions #325
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
c9481e5
to
5a73cee
Compare
This line seems too subjective for this page: "EngFlow helps everyone get more value from Bazel by upstreaming changes in the interest of customers, and by connecting them to experts in the Bazel ecosystem.". Perhaps it can be re-worded or excluded. |
I've updated it to read |
We have partnerships with other Bazel experts, who may help our customers on specific topics, e.g. migrating to Bazel.
Yes, of course! You can see recent commits by EngFlow here: https://github.com/bazelbuild/bazel/commits?author=benjaminp There's also some open PRs, e.g.
It gives more information on how we help customers make Bazel work even better for them. |
> Thanks. I don't understand this phrase, "and by connecting them to
experts in the Bazel ecosystem".
We have partnerships with other Bazel experts, who may help our customers
on specific topics, e.g. migrating to Bazel.
You might want to change the line to say something like "and has
partnerships with other Bazel Experts" or something similar.
Yes, of course! You can see recent commits by EngFlow here:
It would be great to see specific examples of commits that are where
EngFlow is upstreaming work done for specific customers vs all commits by
all engineers.
It gives more information on how we help customers make Bazel work even
better for them.
Okay. Thanks.
Joe
…On Thu, Sep 23, 2021 at 9:04 AM Sara Adams ***@***.***> wrote:
Thanks. I don't understand this phrase, "and by connecting them to experts
in the Bazel ecosystem".
We have partnerships with other Bazel experts, who may help our customers
on specific topics, e.g. migrating to Bazel.
By the way, do you have a few examples of this: "EngFlow upstreams Bazel
changes in the interest of customers"?
Yes, of course! You can see recent commits by EngFlow here:
https://github.com/bazelbuild/bazel/commits?author=benjaminp
https://github.com/bazelbuild/bazel/commits?author=Yannic
https://github.com/bazelbuild/bazel/commits?author=ulfjack
https://github.com/bazelbuild/bazel/commits?author=laszlocsomor
There's also some open PRs, e.g.
bazelbuild/bazel#12719 <bazelbuild/bazel#12719>
bazelbuild/bazel#12112 <bazelbuild/bazel#12112>
Also, how does page "https://www.engflow.com/product/bazelForYou" relate
to the text surrounding it?
It gives more information on how we help customers make Bazel work even
better for them.
https://www.engflow.com/product/bazelForYou#openSourceContributions lists
some Bazel contributions and current projects for our customers. C&P:
"We are actively working on multiple Bazel improvements, including: remote
persistent workers, Java coverage, Kotlin rules, and C++ Include scanning.
We also co-maintain bazelbuild/rules_proto."
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEF5FNMGD7VWDJYR6Z7DE3UDNFYBANCNFSM5ERYDMZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Joe Hicks*Product Manager, Google Core Developer
|
Here are a couple of examples: bazelbuild/bazel@0a75645 bazelbuild/bazel#12719 bazelbuild/bazel#13808 |
Hi. You might want to change your blurb to say something like "and has partnerships with other Bazel Experts" or something similar. Let me know when you have made any changes and I will take a look. |
We discussed and prefer the current wording. |
I am sorry that I can't approve the change with the currently proposed wording. |
No worries, I didn't read it as a requirement, but we're happy to adjust. |
Before and after screenshots:
Bazel Community Experts:
Remote Execution Services: